Skip to content

Clean up needless imports in main.py and remove test_main_regression.py.#1921

Merged
rolandwalker merged 1 commit into
mainfrom
RW/clean-up-main-py-and-main-regression-tests
Jun 6, 2026
Merged

Clean up needless imports in main.py and remove test_main_regression.py.#1921
rolandwalker merged 1 commit into
mainfrom
RW/clean-up-main-py-and-main-regression-tests

Conversation

@rolandwalker
Copy link
Copy Markdown
Contributor

Description

Clean up needless imports in main.py and remove test_main_regression.py.

test_main_regression.py was a low-quality, fully agent-generated file, only meant to aid in refactoring. This was always intended to be deleted, and the main refactoring is finished.

test_main_regression.py was also the main reason that main.py had a series of otherwise needless imports, which are removed here. Various test and non-test files are updated to find the imports more directly.

This does formally reduce test coverage to 97%. That gap can be closed in followups, more carefully than was done in test_main_regression.py.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Jun 6, 2026
and remove test_main_regression.py.

test_main_regression.py was a low-quality, fully agent-generated file,
only meant to aid in refactoring.  This was always intended to be
deleted, and the main refactoring is finished.

test_main_regression.py was also the main reason that main.py had a
series of otherwise needless imports, which are removed here.  Various
test and non-test files are updated to find the imports more directly.

This does formally reduce test coverage to 97%.  That gap can be closed
in followups, more carefully than was done in test_main_regression.py.
@rolandwalker rolandwalker force-pushed the RW/clean-up-main-py-and-main-regression-tests branch from bea139e to eee659b Compare June 6, 2026 16:02
@rolandwalker rolandwalker requested review from amjith and scottnemes June 6, 2026 16:07
@rolandwalker rolandwalker merged commit 4648321 into main Jun 6, 2026
11 checks passed
@rolandwalker rolandwalker deleted the RW/clean-up-main-py-and-main-regression-tests branch June 6, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants